go/runtime/host/sgx: Update QE target info during re-attestation #5239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/sgx-update-targetinfo
branch
from
bd9c8b3
to
2c10d6d
Compare
This allows the node to continue working in case aesmd is upgraded while the node is running. In this case the Quoting Enclave identity can change and this requires the target info to be updated.
kostko
force-pushed
the
kostko/feature/sgx-update-targetinfo
branch
from
2c10d6d
to
5f6e961
Compare
Codecov Report
@@ Coverage Diff @@
## master #5239 +/- ##
==========================================
- Coverage 67.05% 66.89% -0.16%
==========================================
Files 512 512
Lines 54279 54293 +14
==========================================
- Hits 36395 36320 -75
- Misses 13455 13523 +68
- Partials 4429 4450 +21
... and 40 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
peternose
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5238
This allows the node to continue working in case aesmd is upgraded while the node is running. In this case the Quoting Enclave identity can change and this requires the target info to be updated.