go/worker/compute/executor: Do not propose batch on epoch transition #5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/exec-proposal-epochtransition
branch
2 times, most recently
from
3041037
to
414c912
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
peternose
approved these changes
May 19, 2023
There was a problem hiding this comment.
Tested, looks ok.
{"caller":"node.go:511","level":"debug","module":"worker/executor/committee","msg":"not scheduling a batch, incorrect state","runtime_id":"8000000000000000000000000000000000000000000000000000000000000000","state":"WaitingForFinalize","ts":"2023-05-19T09:50:37.127248029Z"}
{"caller":"node.go:536","level":"debug","module":"worker/executor/committee","msg":"next consensus block is an epoch transition, not scheduling batch","runtime_id":"8000000000000000000000000000000000000000000000000000000000000000","ts":"2023-05-19T09:50:37.551501162Z"}
{"caller":"node.go:536","level":"debug","module":"worker/executor/committee","msg":"next consensus block is an epoch transition, not scheduling batch","runtime_id":"8000000000000000000000000000000000000000000000000000000000000000","ts":"2023-05-19T09:50:37.654546076Z"}
{"caller":"node.go:536","level":"debug","module":"worker/executor/committee","msg":"next consensus block is an epoch transition, not scheduling batch","runtime_id":"8000000000000000000000000000000000000000000000000000000000000000","ts":"2023-05-19T09:50:38.127776063Z"}
{"caller":"node.go:511","level":"debug","module":"worker/executor/committee","msg":"not scheduling a batch, incorrect state","runtime_id":"8000000000000000000000000000000000000000000000000000000000000000","state":"WaitingForFinalize","ts":"2023-05-19T09:50:39.767028161Z"}
Previously a compute node could propose a new batch just before the epoch transition happened, resulting in computation that will be discarded anyway.
kostko
force-pushed
the
kostko/feature/exec-proposal-epochtransition
branch
from
414c912
to
54d8c1f
Compare
peternose
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a compute node could propose a new batch just before the epoch transition happened, resulting in computation that will be discarded anyway.