go/oasis-test-runner: Refactor e2e tests #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
approved these changes
May 22, 2023
peternose
force-pushed
the
peternose/internal/upgrade-tests-refactoring
branch
3 times, most recently
from
45f9379
to
75cfa06
Compare
In SGX mode, it is essential to refresh the runtime bundles before configuring the key manager runtime's policy. This ensures that the policy includes the most up-to-date enclave IDs.
The runtime test clients have been consolidated into a more robust client capable of executing arbitrary key/value runtime scenarios. This enhancement gives E2E tests greater control over the operations being tested.
The runtime fixture configuration has been updated to allow the retention of runtime bundles after the completion of an E2E scenario.
The flags for specifying the runtime source and target directories have been moved from the trust root scenario to the runtime scenario. This change simplifies the buildkite scripts and enables all runtime scenarios to utilize these folders in their tests.
The implementation of the runtime scenario and some of its methods have been made public, allowing them to be used in E2E tests outside of this repository.
The scenarios e2e.E2E and runtime.RuntimeImpl were renamed to e2e.Scenario and runtime.Scenario, respectively, to address stuttering issues when used by other packages.
The key manager upgrade scenario has been refactored to retrieve the entity's nonce and the key manager's old deployments from the consensus layer. This modification enables the test to be used in cross-version test scenarios, where the nonce and the deployments are defined in the pre-upgrade scenario.
peternose
force-pushed
the
peternose/internal/upgrade-tests-refactoring
branch
from
75cfa06
to
28622d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base changes for E2E upgrade tests.