go/roothash: Optimize and refactor commitment pool processing #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commitment pool processing has been optimized and refactored to improve code readability. The discrepancy detection has been modified to immediately switch to the resolution mode when two commits differ, eliminating the necessity to wait for the proposer's commitment. The discrepancy resolution process was redesigned to fail as soon as it becomes evident that no group of votes can attain the majority, such as when there are too many failures.
peternose
force-pushed
the
peternose/internal/refactor-commitment-pool-processing
branch
from
23b4ed3
to
e7b4a26
Compare
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
approved these changes
May 30, 2023
peternose
deleted the
peternose/internal/refactor-commitment-pool-processing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commitment pool processing has been optimized and refactored to improve code readability.