Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CometBFT to v0.37.1 #5280

Merged
merged 1 commit into from Jun 13, 2023
Merged

Conversation

abukosek
Copy link
Contributor

@abukosek abukosek commented Jun 6, 2023

This PR bumps CometBFT to v0.37.1. This version renamed everything and added some breaking changes that this PR also fixes.

TODO:

  • Bump version & replace all imports.
  • Rename imports tm->cmt.
  • Make unit tests work.
  • Make e2e tests work.
    - [ ] Rename our go/consensus/tendermint directory to go/consensus/cometbft. -- will do this in a separate PR to reduce breakage :)

@abukosek abukosek force-pushed the andrej/feature/bump-cometbft-0.37.1 branch 10 times, most recently from f22daa0 to 1dd2294 Compare June 13, 2023 11:52
@abukosek abukosek marked this pull request as ready for review June 13, 2023 12:09
go/consensus/tendermint/api/api.go Outdated Show resolved Hide resolved
go/go.mod Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #5280 (1dd2294) into master (f762461) will decrease coverage by 0.01%.
The diff coverage is 72.52%.

❗ Current head 1dd2294 differs from pull request most recent head 5523600. Consider uploading reports for the commit 5523600 to get more accurate results

@@            Coverage Diff             @@
##           master    #5280      +/-   ##
==========================================
- Coverage   66.47%   66.46%   -0.01%     
==========================================
  Files         517      517              
  Lines       54898    54903       +5     
==========================================
  Hits        36493    36493              
- Misses      13920    13929       +9     
+ Partials     4485     4481       -4     
Impacted Files Coverage Δ
go/consensus/tendermint/abci/state.go 72.28% <ø> (ø)
go/consensus/tendermint/api/app.go 0.00% <ø> (ø)
...nsensus/tendermint/apps/beacon/backend_insecure.go 60.43% <ø> (ø)
go/consensus/tendermint/apps/beacon/backend_vrf.go 60.59% <ø> (ø)
go/consensus/tendermint/apps/beacon/beacon.go 70.96% <ø> (ø)
go/consensus/tendermint/apps/beacon/genesis.go 69.69% <ø> (+6.06%) ⬆️
go/consensus/tendermint/apps/governance/genesis.go 58.33% <ø> (ø)
...consensus/tendermint/apps/governance/governance.go 57.88% <ø> (ø)
go/consensus/tendermint/apps/keymanager/genesis.go 56.14% <ø> (ø)
...consensus/tendermint/apps/keymanager/keymanager.go 74.09% <ø> (ø)
... and 44 more

... and 28 files with indirect coverage changes

@abukosek abukosek force-pushed the andrej/feature/bump-cometbft-0.37.1 branch from 1dd2294 to 191c5e1 Compare June 13, 2023 12:30
@abukosek abukosek force-pushed the andrej/feature/bump-cometbft-0.37.1 branch from 191c5e1 to 5523600 Compare June 13, 2023 12:32
@abukosek abukosek merged commit 653c04b into master Jun 13, 2023
3 checks passed
@abukosek abukosek deleted the andrej/feature/bump-cometbft-0.37.1 branch June 13, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants