runtime/consensus/tendermint/verifier: Support same-block validation #5300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
reviewed
Jul 3, 2023
kostko
reviewed
Jul 3, 2023
peternose
force-pushed
the
peternose/feature/same-block-validation
branch
from
d640e69
to
ebf412c
Compare
peternose
added
c:breaking/runtime
kostko
approved these changes
Jul 4, 2023
| if err != nil { | ||
| return nil, fmt.Errorf("client: failed to get epoch at height %d: %w", annBlk.Height, err) | ||
| } | ||
| // TODO: Remove once same block consensus validation is deployed. |
There was a problem hiding this comment.
Created a task for this so we don't forget.
There was a problem hiding this comment.
Will create a draft PR also.
Yeah, makes sense, will open an issue. |
peternose
force-pushed
the
peternose/feature/same-block-validation
branch
from
ebf412c
to
0b29088
Compare
The post-execution state of the latest consensus block is now verified using the block metadata transaction, effectively eliminating any block delay for state verification.
peternose
force-pushed
the
peternose/feature/same-block-validation
branch
from
0b29088
to
167d666
Compare
This was referenced Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using metadata transaction to verify the latest consensus block. These changes should allow queries for the latest runtime state.
Currently, light blocks are fetched twice for the same height, i.e. before sending light block to the runtime, and when doing runtime header verification. This could be optimized by sending height instead of a block.