go/oasis-test-runner: Reorganize e2e tests #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
force-pushed
the
peternose/trivial/reorganize-e2e-tests
branch
3 times, most recently
from
59f65a2
to
0f04c7a
Compare
When the runtime binary was upgraded before the key manager binary, the key manager was unable to decode long-term key requests due to the inclusion of a master secret generation number. As a result, all secure transactions failed, returning an unknown field error.
Group similar runtime scenario methods and make them globally available.
The runtime test client interface is no longer needed since we only have one implementation of the client.
Now, a runtime client can run multiple scenarios without the need to change the seed.
Other scenarios can now use this code to upgrade the simple key value runtime or the key manager runtime.
A scenario can now refresh a single bundle, without overwriting others.
The Tendermint verifier now stores the trusted root under a key derived from the enclave's identity and the runtime version. Relying solely on the identity is not sufficient, as on non-SGX platforms, the identity is set to the default value, causing new runtimes in the upgrade tests to use trusted roots from the previous versions, which may not even be compatible.
peternose
force-pushed
the
peternose/trivial/reorganize-e2e-tests
branch
from
0f04c7a
to
8f34ee2
Compare
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
approved these changes
Jul 19, 2023
ptrus
pushed a commit
that referenced
this pull request
Jul 19, 2023
…ize-e2e-tests go/oasis-test-runner: Reorganize e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code generalization/deduplication, minor bug fixes and some extra methods that will be used by the upgrade-test for master secret rotations.