Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/p2p: collect Prometheus metrics #5327

Merged
merged 1 commit into from Jul 20, 2023
Merged

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jul 19, 2023

The issue called for adding a metric for number of blocked p2p peers specifically. Decided to add some other useful P2P metrics as well.

If there's any other P2P metrics that would be nice to collect, feel free to suggest.

Testing

Tested locally with E2E tests and metrics enabled:
test

@ptrus ptrus force-pushed the ptrus/feature/p2p-blocked-peers branch 2 times, most recently from d84698b to 245de6e Compare July 19, 2023 16:10
@ptrus ptrus marked this pull request as ready for review July 19, 2023 16:11
@ptrus ptrus force-pushed the ptrus/feature/p2p-blocked-peers branch from 245de6e to 1f8bd34 Compare July 20, 2023 07:12
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #5327 (1f8bd34) into master (9551d85) will decrease coverage by 0.02%.
The diff coverage is 37.93%.

❗ Current head 1f8bd34 differs from pull request most recent head fdb3d92. Consider uploading reports for the commit fdb3d92 to get more accurate results

@@            Coverage Diff             @@
##           master    #5327      +/-   ##
==========================================
- Coverage   66.96%   66.95%   -0.02%     
==========================================
  Files         524      525       +1     
  Lines       55781    55809      +28     
==========================================
+ Hits        37355    37368      +13     
- Misses      13875    13897      +22     
+ Partials     4551     4544       -7     
Impacted Files Coverage Δ
go/p2p/metrics.go 18.18% <18.18%> (ø)
go/p2p/p2p.go 72.59% <100.00%> (+0.62%) ⬆️

... and 54 files with indirect coverage changes

go/p2p/metrics.go Outdated Show resolved Hide resolved
go/p2p/p2p.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/p2p-blocked-peers branch from 1f8bd34 to fdb3d92 Compare July 20, 2023 08:25
@ptrus ptrus enabled auto-merge July 20, 2023 08:40
@ptrus ptrus merged commit ac9520c into master Jul 20, 2023
3 checks passed
@ptrus ptrus deleted the ptrus/feature/p2p-blocked-peers branch July 20, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants