Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/roothash: Track runtime proposer liveness #5334

Merged
merged 1 commit into from Aug 3, 2023

Conversation

peternose
Copy link
Contributor

The roothash application now monitors the runtime proposer liveness, which runtimes can utilize to penalize proposers with insufficient commitments.

@peternose peternose force-pushed the peternose/feature/track-proposer-liveness branch from f017a52 to 42c27c5 Compare August 1, 2023 18:55
@peternose peternose marked this pull request as ready for review August 1, 2023 20:58
.changelog/5334.feature.md Outdated Show resolved Hide resolved
go/registry/api/runtime.go Show resolved Hide resolved
The roothash application now monitors the runtime proposer liveness, which
runtimes can utilize to penalize proposers with insufficient commitments.
@peternose peternose force-pushed the peternose/feature/track-proposer-liveness branch from 42c27c5 to 67711fa Compare August 2, 2023 13:45
@peternose peternose added golang rust c:breaking Category: breaking code change labels Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #5334 (67711fa) into master (4425f68) will decrease coverage by 0.24%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##           master    #5334      +/-   ##
==========================================
- Coverage   67.64%   67.40%   -0.24%     
==========================================
  Files         525      525              
  Lines       55816    55899      +83     
==========================================
- Hits        37754    37676      -78     
- Misses      13534    13691     +157     
- Partials     4528     4532       +4     
Files Changed Coverage Δ
go/registry/api/runtime.go 53.06% <ø> (ø)
go/consensus/cometbft/apps/roothash/roothash.go 73.02% <60.00%> (-0.14%) ⬇️
...o/consensus/cometbft/apps/roothash/transactions.go 70.21% <66.66%> (-5.34%) ⬇️
go/scheduler/api/api.go 60.37% <70.58%> (-0.23%) ⬇️
go/consensus/cometbft/apps/roothash/liveness.go 83.33% <100.00%> (+5.33%) ⬆️
go/roothash/api/liveness.go 100.00% <100.00%> (ø)
go/roothash/tests/tester.go 90.20% <100.00%> (+0.86%) ⬆️

... and 55 files with indirect coverage changes

@peternose peternose merged commit 3293d29 into master Aug 3, 2023
4 of 5 checks passed
@peternose peternose deleted the peternose/feature/track-proposer-liveness branch August 3, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking Category: breaking code change golang rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants