Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/common: Display additional information in the liveness status #5402

Merged
merged 1 commit into from Oct 12, 2023

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Oct 12, 2023

oasis-node control status -a compute-2-internal-3562597129.sock
        "liveness": {
          "total_rounds": 15,
          "live_rounds": 15,
          "finalized_proposals": 7,
          "missed_proposals": 0
        },

@peternose peternose marked this pull request as ready for review October 12, 2023 15:35
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #5402 (87fac85) into master (1d12295) will increase coverage by 0.29%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5402      +/-   ##
==========================================
+ Coverage   66.18%   66.47%   +0.29%     
==========================================
  Files         534      534              
  Lines       56322    56324       +2     
==========================================
+ Hits        37279    37444     +165     
+ Misses      14614    14447     -167     
- Partials     4429     4433       +4     
Files Coverage Δ
go/roothash/api/liveness.go 100.00% <ø> (ø)
go/worker/common/api/api.go 19.67% <ø> (+6.55%) ⬆️
go/worker/common/committee/node.go 60.52% <100.00%> (+0.61%) ⬆️

... and 68 files with indirect coverage changes

@peternose peternose merged commit 58db182 into master Oct 12, 2023
6 checks passed
@peternose peternose deleted the peternose/trivial/liveness-status branch October 12, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants