go/worker/compute/executor: Propose promptly upon detecting discrepancy #5447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5447 +/- ##
==========================================
- Coverage 66.99% 66.73% -0.26%
==========================================
Files 533 533
Lines 56383 56384 +1
==========================================
- Hits 37773 37628 -145
- Misses 14211 14326 +115
- Partials 4399 4430 +31 ☔ View full report in Codecov by Sentry. |
kostko
approved these changes
Nov 15, 2023
Pipes created by a call to channels.Unwrap spawned new goroutines that were not terminated during runtime restarts. These zombie pipes also intercepted one value from the newly created pipes, causing them to block indefinitely.
peternose
force-pushed
the
peternose/bugfix/delayed-discrepancy
branch
from
9ca5f9e
to
30cac2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.