Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/keymanager: Decouple secrets from key manager worker #5538

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Jan 23, 2024

Moved secrets away from the main key manager worker. Major changes:

  • Registration (see handleRuntimeHostEvent):
    • The key manager worker is responsible for updating capabilities and version on every start and update.
    • The secrets worker is responsible for updating extra info on restarts (RAK changes) and when checksum changes.
  • Key manager status was changed.
    • The idea is to capture global values (e.g. runtime_id, access_list) at the top, and move secrets specific values under section secrets which will be latter accompanied by section churp.
  • Status state can be found in the key manager worker status and in the secrets status (can be also changed).
  • The key manager is initialized when all sub-workers are initialized (currently we have only one worker for secrets).

@peternose peternose force-pushed the peternose/trivial/km-decouple-secrets branch from 4f2dd89 to c7f41dd Compare January 23, 2024 19:53
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (6012717) 66.25% compared to head (9d1ddaf) 66.19%.
Report is 3 commits behind head on master.

❗ Current head 9d1ddaf differs from pull request most recent head ae42c0e. Consider uploading reports for the commit ae42c0e to get more accurate results

Files Patch % Lines
go/worker/keymanager/secrets.go 84.09% 61 Missing and 29 partials ⚠️
go/worker/keymanager/worker.go 86.95% 6 Missing and 3 partials ⚠️
go/worker/keymanager/init.go 76.47% 2 Missing and 2 partials ⚠️
go/runtime/registry/host.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5538      +/-   ##
==========================================
- Coverage   66.25%   66.19%   -0.07%     
==========================================
  Files         537      538       +1     
  Lines       56810    56868      +58     
==========================================
+ Hits        37637    37641       +4     
- Misses      14768    14798      +30     
- Partials     4405     4429      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternose peternose force-pushed the peternose/trivial/km-decouple-secrets branch 2 times, most recently from b39dd4b to 6f65753 Compare January 24, 2024 15:14
@peternose peternose marked this pull request as ready for review January 24, 2024 15:44
@peternose peternose force-pushed the peternose/trivial/km-decouple-secrets branch from 6f65753 to 9d1ddaf Compare January 24, 2024 15:48
@peternose peternose force-pushed the peternose/trivial/km-decouple-secrets branch from 9d1ddaf to ae42c0e Compare January 25, 2024 14:39
@peternose peternose merged commit 094f5e5 into master Jan 25, 2024
4 checks passed
@peternose peternose deleted the peternose/trivial/km-decouple-secrets branch January 25, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants