Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keymanager/src/churp: Handle init RPC requests #5569

Merged
merged 3 commits into from Feb 26, 2024
Merged

keymanager/src/churp: Handle init RPC requests #5569

merged 3 commits into from Feb 26, 2024

Conversation

peternose
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Feb 24, 2024 •
edited

✅ Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit b920d74
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/65dc896006178500087b19d3

@peternose peternose force-pushed the peternose/feature/churp-handler branch 3 times, most recently from c3dbfc6 to d0011d6 Compare February 24, 2024 06:00
@peternose peternose force-pushed the peternose/feature/churp-handler branch from d0011d6 to f52b358 Compare February 24, 2024 12:42
@peternose peternose marked this pull request as ready for review February 24, 2024 13:09
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.17%. Comparing base (2a1baa1) to head (f52b358).
Report is 1 commits behind head on master.

❗ Current head f52b358 differs from pull request most recent head b920d74. Consider uploading reports for the commit b920d74 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5569      +/-   ##
==========================================
- Coverage   65.60%   65.17%   -0.44%     
==========================================
  Files         576      576              
  Lines       58613    58613              
==========================================
- Hits        38454    38200     -254     
- Misses      15666    15937     +271     
+ Partials     4493     4476      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kostko
kostko reviewed Feb 24, 2024
View reviewed changes
keymanager/src/churp/storage.rs Outdated Show resolved Hide resolved
keymanager/src/churp/types.rs Outdated Show resolved Hide resolved
keymanager/src/churp/handler.rs Show resolved Hide resolved
keymanager/src/churp/handler.rs Outdated Show resolved Hide resolved
runtime/src/consensus/state/keymanager/churp.rs Outdated Show resolved Hide resolved
keymanager/src/churp/handler.rs Outdated Show resolved Hide resolved
keymanager/src/churp/handler.rs Outdated Show resolved Hide resolved
@peternose peternose force-pushed the peternose/feature/churp-handler branch from c5ae3ca to f8d3af3 Compare February 26, 2024 12:02
@peternose peternose force-pushed the peternose/feature/churp-handler branch from f8d3af3 to b920d74 Compare February 26, 2024 12:51
@peternose peternose merged commit 169dbdd into master Feb 26, 2024
3 of 5 checks passed
@peternose peternose deleted the peternose/feature/churp-handler branch February 26, 2024 13:14
@kostko kostko mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peternose @kostko