go/worker/storage: Make fetch pool per-runtime #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
This should speed up storage sync in case of nodes that have multiple runtimes configured.
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
kostko
force-pushed
the
kostko/feature/storage-perrt-fetchpool
branch
from
e7e2a9a
to
82bb7b2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5595 +/- ##
==========================================
- Coverage 66.11% 66.00% -0.11%
==========================================
Files 588 588
Lines 60089 60085 -4
==========================================
- Hits 39728 39662 -66
- Misses 15742 15790 +48
- Partials 4619 4633 +14 ☔ View full report in Codecov by Sentry. |
peternose
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed up storage sync in case of nodes that have multiple runtimes configured.