Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/keymanager: Fix node ACL management #5613

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

jberci
Copy link
Contributor

@jberci jberci commented Mar 28, 2024

No description provided.

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 1c14a33
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/660865715903e70009870cfe

.changelog/5613.bugfix.md Outdated Show resolved Hide resolved
go/worker/keymanager/watcher.go Outdated Show resolved Hide resolved
go/worker/keymanager/watcher.go Outdated Show resolved Hide resolved
@jberci jberci marked this pull request as ready for review March 28, 2024 15:04
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 65.87%. Comparing base (658fc23) to head (1c14a33).
Report is 1 commits behind head on master.

Files Patch % Lines
go/worker/keymanager/watcher.go 50.00% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5613      +/-   ##
==========================================
- Coverage   66.08%   65.87%   -0.22%     
==========================================
  Files         590      590              
  Lines       60212    60211       -1     
==========================================
- Hits        39792    39662     -130     
- Misses      15783    15880      +97     
- Partials     4637     4669      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jberci jberci merged commit 6c420cf into master Mar 30, 2024
5 of 7 checks passed
@jberci jberci deleted the jberci/fix/observers branch March 30, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants