Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secret-sharing/src/churp: Implement handoff #5617

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Mar 29, 2024

No description provided.

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit d01fe6d
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/660d3b272a544c00085fa12e

@peternose peternose force-pushed the peternose/feature/churp-handoff branch 2 times, most recently from 400a1e9 to 0eeaac8 Compare March 29, 2024 15:41
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments, looks good to me otherwise.

secret-sharing/src/churp/player.rs Outdated Show resolved Hide resolved
secret-sharing/src/churp/player.rs Outdated Show resolved Hide resolved
secret-sharing/src/churp/handoff.rs Outdated Show resolved Hide resolved
secret-sharing/src/churp/switch.rs Outdated Show resolved Hide resolved
secret-sharing/src/churp/switch.rs Outdated Show resolved Hide resolved
secret-sharing/src/churp/switch.rs Outdated Show resolved Hide resolved
secret-sharing/src/churp/switch.rs Outdated Show resolved Hide resolved
secret-sharing/src/churp/switch.rs Show resolved Hide resolved
secret-sharing/src/churp/handoff.rs Outdated Show resolved Hide resolved
secret-sharing/src/churp/handoff.rs Outdated Show resolved Hide resolved
@peternose peternose force-pushed the peternose/feature/churp-handoff branch from be6d683 to 69bd896 Compare April 3, 2024 10:55
@peternose peternose force-pushed the peternose/feature/churp-handoff branch from 69bd896 to 9a8a097 Compare April 3, 2024 11:16
Defines the threshold as a strict lower bound for the number
of shares required to reconstruct the shared secret, aligning
with the CHHUP paper.
For security reasons, do not allow printing the debug representation
of secret polynomials.
Rename shareholders to pending_shareholders, replace word
randomize with proactivize and fix the names of some
methods.
@peternose peternose force-pushed the peternose/feature/churp-handoff branch from 9a8a097 to d01fe6d Compare April 3, 2024 11:19
@peternose peternose enabled auto-merge April 3, 2024 11:22
@peternose peternose merged commit cba7188 into master Apr 3, 2024
5 checks passed
@peternose peternose deleted the peternose/feature/churp-handoff branch April 3, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants