-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secret-sharing/src/churp: Implement handoff #5617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
March 29, 2024 13:24
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
peternose
force-pushed
the
peternose/feature/churp-handoff
branch
2 times, most recently
from
March 29, 2024 15:41
400a1e9
to
0eeaac8
Compare
kostko
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments, looks good to me otherwise.
peternose
force-pushed
the
peternose/feature/churp-handoff
branch
from
April 3, 2024 10:55
be6d683
to
69bd896
Compare
kostko
approved these changes
Apr 3, 2024
peternose
force-pushed
the
peternose/feature/churp-handoff
branch
from
April 3, 2024 11:16
69bd896
to
9a8a097
Compare
Defines the threshold as a strict lower bound for the number of shares required to reconstruct the shared secret, aligning with the CHHUP paper.
For security reasons, do not allow printing the debug representation of secret polynomials.
Rename shareholders to pending_shareholders, replace word randomize with proactivize and fix the names of some methods.
peternose
force-pushed
the
peternose/feature/churp-handoff
branch
from
April 3, 2024 11:19
9a8a097
to
d01fe6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.