Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple minor runtime-related improvements #5637

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 11, 2024

No description provided.

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 9ce6106
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/6617d27b56afbe0008d772ae

@kostko kostko force-pushed the kostko/feature/rt-registry-improve branch from 3019a78 to 509314b Compare April 11, 2024 10:40
@kostko kostko marked this pull request as ready for review April 11, 2024 10:40
@kostko kostko force-pushed the kostko/feature/rt-registry-improve branch from 509314b to c6f29d7 Compare April 11, 2024 10:54
continue // Always enabled above.
}

// By default honor the status of the component itself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be done top-down:

// Check for any overrides in the node configuration.
compCfg, ok := config.GlobalConfig.Runtime.GetComponent(comp.ID())
if ok && compCfg.Disabled {
	continue
}

// On non-compute nodes, assume all components are disabled by default.
if !ok && config.GlobalConfig.Mode != config.ModeCompute {
	continue
}

// By default honor the status of the component itself.
if !ok && comp.Disabled {
	continue
}

@kostko kostko force-pushed the kostko/feature/rt-registry-improve branch from c6f29d7 to 9ce6106 Compare April 11, 2024 12:07
@kostko kostko enabled auto-merge April 11, 2024 12:27
@kostko kostko merged commit 8d5b667 into master Apr 11, 2024
5 checks passed
@kostko kostko deleted the kostko/feature/rt-registry-improve branch April 11, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants