go/worker/keymanager/churp: Orchestrate handoffs #5640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
peternose
force-pushed
the
peternose/feature/handoffs
branch
2 times, most recently
from
fcc9101
to
be0b850
Compare
kostko
reviewed
Apr 17, 2024
|
|
||
| /// Encoded secret share. | ||
| #[derive(Clone, Default, cbor::Encode, cbor::Decode)] | ||
| pub struct EncodedSecretShare { |
There was a problem hiding this comment.
This should probably derive Zeroize with #[zeroize(drop)] as it contains secret data. Possibly elsewhere as well (e.g. SecretShare).
There was a problem hiding this comment.
Agree. Working on this.
There was a problem hiding this comment.
Will be done in another PR.
peternose
force-pushed
the
peternose/feature/handoffs
branch
from
be0b850
to
38f8930
Compare
kostko
reviewed
Apr 18, 2024
peternose
force-pushed
the
peternose/feature/handoffs
branch
from
2f4cac6
to
d07e5df
Compare
kostko
approved these changes
Apr 19, 2024
peternose
force-pushed
the
peternose/feature/handoffs
branch
from
d07e5df
to
8af7e05
Compare
The enclave call will always fail with the error 'unknown peer id' if the nodes to which the call should be directed are not part of the committee. To prevent the call from being directed to a random key manager node, an error should be returned instead.
Support storing the secret share of a player to prevent its loss during restarts or failures.
Generalizes the initialization request so that it can also be used for other requests with the same parameters.
peternose
force-pushed
the
peternose/feature/handoffs
branch
from
8af7e05
to
7673734
Compare
kostko
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.