bugfix: KVStore (analyzer cache): Fix retrieval and error handling #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew7234
changed the title
ptrus
reviewed
May 5, 2023
mitjat
force-pushed
the
andrew7234/cache-fix
branch
2 times, most recently
from
f8d29c7
to
729d71c
Compare
ptrus
approved these changes
May 5, 2023
pro-wh
reviewed
May 5, 2023
storage/oasis/nodeapi/file/common.go
Outdated
| if err2 != nil { | ||
| cache.logger.Warn(fmt.Sprintf("failed to unmarshal key %s from cache into %T: %v", key.Pretty(), result, err2)) | ||
| } | ||
| var result *Value |
There was a problem hiding this comment.
you have it unmarshal into a nil pointer? 🤨
There was a problem hiding this comment.
It was supposed to be a quick blind&untested fix, more like a suggestion to the existing PR. Instead, my commits became its own thing now. Thanks, fixed, and added unit tests.
mitjat
changed the title
mitjat
changed the title
ptrus
reviewed
May 9, 2023
mitjat
force-pushed
the
andrew7234/cache-fix
branch
from
7bb0e09
to
48366eb
Compare
Co-authored-by: Peter Us <peter@u-s.si>
mitjat
force-pushed
the
andrew7234/cache-fix
branch
from
48366eb
to
1a06549
Compare
mitjat
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Mitja] This PR cleans up KVStore and fixes a bug in the process:
GetFromCacheOrCallwhere if a value was in the cache, we used to not use itGetFromCacheOrCallwhere if a value was in the cache but couldn't be retrieved correctly (e.g. because of the wrong type), we logged too many errors