Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add support for dumping deployed WASM of contracts #1007

Merged
merged 4 commits into from
Jul 4, 2022

Conversation

matevz
Copy link
Member

@matevz matevz commented Jun 20, 2022

  • Adds contracts.CodeStorage to runtime API which returns the stored Wasm code.
  • Updates client-sdk/go bindings.
  • Updates client-sdk/ts-web bindings
  • Implements it in oasis CLI (oasis contracts dump-code).

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1007 (a238c92) into main (d12b712) will decrease coverage by 0.02%.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
- Coverage   67.99%   67.96%   -0.03%     
==========================================
  Files         128      128              
  Lines       11001    11017      +16     
==========================================
+ Hits         7480     7488       +8     
- Misses       3489     3497       +8     
  Partials       32       32              
Impacted Files Coverage Δ
client-sdk/go/modules/contracts/contracts.go 0.00% <0.00%> (ø)
client-sdk/go/modules/contracts/types.go 40.00% <ø> (ø)
runtime-sdk/modules/contracts/src/code.rs 100.00% <ø> (ø)
runtime-sdk/modules/contracts/src/types.rs 95.23% <ø> (ø)
runtime-sdk/modules/contracts/src/lib.rs 65.02% <83.33%> (+0.31%) ⬆️
runtime-sdk/modules/contracts/src/test.rs 97.60% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12b712...a238c92. Read the comment docs.

@matevz matevz force-pushed the matevz/feature/cli-dump-wasm-code branch from db9d93b to 6a753b4 Compare June 27, 2022 13:54
cli/cmd/contracts.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/cli-dump-wasm-code branch 2 times, most recently from a0169a4 to 3224ed7 Compare June 28, 2022 10:13
@matevz matevz marked this pull request as ready for review June 28, 2022 10:13
@matevz matevz requested review from pro-wh and ptrus as code owners June 28, 2022 10:13
@matevz matevz force-pushed the matevz/feature/cli-dump-wasm-code branch from 3224ed7 to 6f6c4c7 Compare June 28, 2022 10:21
cli/cmd/contracts.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/cli-dump-wasm-code branch from 6f6c4c7 to f041abd Compare June 28, 2022 11:06
runtime-sdk/modules/contracts/src/types.rs Outdated Show resolved Hide resolved
runtime-sdk/modules/contracts/src/types.rs Show resolved Hide resolved
client-sdk/go/modules/contracts/types.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/cli-dump-wasm-code branch 2 times, most recently from 435e987 to 64b71b7 Compare June 30, 2022 14:57
@matevz matevz requested a review from kostko June 30, 2022 15:17
@matevz matevz force-pushed the matevz/feature/cli-dump-wasm-code branch from 64b71b7 to 65ce21f Compare July 1, 2022 16:06
@matevz matevz force-pushed the matevz/feature/cli-dump-wasm-code branch from 65ce21f to 3b3846f Compare July 1, 2022 16:19
@matevz matevz requested a review from kostko July 1, 2022 16:19
@matevz matevz force-pushed the matevz/feature/cli-dump-wasm-code branch from 3b3846f to ca31dbf Compare July 4, 2022 09:17
@matevz matevz force-pushed the matevz/feature/cli-dump-wasm-code branch from ca31dbf to a238c92 Compare July 4, 2022 09:19
@matevz matevz enabled auto-merge July 4, 2022 09:23
@matevz matevz merged commit b4efbe8 into main Jul 4, 2022
@matevz matevz deleted the matevz/feature/cli-dump-wasm-code branch July 4, 2022 09:43
tjanez pushed a commit to oasisprotocol/cli that referenced this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants