runtime-sdk: Mask gas limit/wanted in case EMIT_GAS_USED_EVENTS is false #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
- Coverage 68.37% 68.37% -0.01%
==========================================
Files 126 126
Lines 10670 10677 +7
==========================================
+ Hits 7296 7300 +4
- Misses 3349 3352 +3
Partials 25 25
Continue to review full report at Codecov.
|
pro-wh
reviewed
Jun 24, 2022
| @@ -158,7 +154,11 @@ impl<Cfg: Config> OasisV1<Cfg> { | |||
| // Compute how much gas was wanted. | |||
| let final_gas = gas::get_remaining_gas(instance); | |||
| let wanted_gas = initial_gas + exhausted_gas.saturating_sub(final_gas); | |||
| core::Error::OutOfGas(initial_gas, wanted_gas).into() | |||
| core::Error::out_of_gas::<<<C::Runtime as Runtime>::Core as core::API>::Config>( | |||
There was a problem hiding this comment.
Yeah unfortunately the Rust compiler wants explicit casts here :(
| /// Generate a proper OutOfGas error, depending on whether the module is configured to emit gas | ||
| /// use information or not. | ||
| pub fn out_of_gas<Cfg: Config>(limit: u64, wanted: u64) -> Self { | ||
| if Cfg::EMIT_GAS_USED_EVENTS { |
There was a problem hiding this comment.
this already existed? what did it do before?
There was a problem hiding this comment.
It suppresses emission of gas used events (which are by default emitted for every transaction). With this PR the same flag is also used for masking exact amounts in out of gas errors.
kostko
force-pushed
the
kostko/feature/mask-gas-errors
branch
from
f2eb52d
to
33fe84d
Compare
pro-wh
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.