runtime-sdk: add RNG #1037

nhynes · 2022-07-06T11:52:59Z

This PR adds a VRF-based RNG to the contract and EVM modules.

codecov · 2022-07-06T11:54:25Z

Codecov Report

Merging #1037 (a7680f3) into main (04944cb) will decrease coverage by 0.60%.
The diff coverage is 48.09%.

@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
- Coverage   65.18%   64.58%   -0.61%     
==========================================
  Files         134      135       +1     
  Lines       12309    12356      +47     
==========================================
- Hits         8024     7980      -44     
- Misses       4253     4344      +91     
  Partials       32       32

Impacted Files	Coverage Δ
client-sdk/go/modules/contracts/types.go	`15.38% <ø> (ø)`
contract-sdk-macros/src/error_derive.rs	`86.07% <ø> (ø)`
contract-sdk-macros/src/event_derive.rs	`88.67% <ø> (ø)`
contract-sdk/src/abi/env.rs	`0.00% <ø> (ø)`
contract-sdk/src/testing.rs	`10.66% <0.00%> (-0.93%)`	⬇️
runtime-sdk-macros/src/error_derive.rs	`83.33% <ø> (ø)`
runtime-sdk-macros/src/method_handler_derive.rs	`93.82% <ø> (ø)`
runtime-sdk/modules/contracts/src/lib.rs	`66.18% <ø> (ø)`
runtime-sdk/modules/evm/src/backend.rs	`58.53% <0.00%> (-4.63%)`	⬇️
runtime-sdk/src/crypto/random.rs	`0.00% <0.00%> (ø)`
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

runtime-sdk/modules/contracts/src/abi/oasis/crypto.rs

runtime-sdk/src/crypto/random.rs

Yawning · 2022-07-10T11:54:44Z

As a side note:

Do we want to expose a VRF construct somewhere so that it would be easy to make a chainlink VRF knockoff?

I think to do it "correctly", you would need prove, verify, and proof to hash (roughly speaking the chainlink design is a 2-step process: commit to alpha in one step, retrieve pi/beta in another step). This is done so that properly coded applications can prevent users/executors/etc from fishing for an alpha value (because it is committed), to get a beta that produces a desired result.

contract-sdk/src/testing.rs

runtime-sdk/modules/contracts/src/abi/oasis/crypto.rs

runtime-sdk/src/crypto/random.rs

runtime-sdk/modules/evm/src/lib.rs

runtime-sdk/modules/evm/src/backend.rs

runtime-sdk/modules/contracts/src/abi/oasis/crypto.rs

runtime-sdk/src/crypto/random.rs

runtime-sdk/modules/contracts/src/abi/oasis/crypto.rs

Yawning · 2022-09-27T08:46:42Z

should clients provide additional pers strings? it might be more secure if used properly, but will people know (how) to use it?

I like having an integrated way to do domain-separation. The case when nothing is provided should (still) be secure if this is done correctly.

nhynes · 2022-12-09T05:19:24Z

runtime-sdk/Cargo.toml

@@ -19,7 +19,8 @@ hmac = "0.11.0"
 sha2 = "0.9.8"
 sha3 = { version = "0.10.1", default-features = false }
 k256 = { version = "0.10.4" }
-schnorrkel = "0.10.2"
+schnorrkel = { version = "0.10.2", features = ["asm", "avx2_backend"] }


I assume these instruction sets are fast and supported (@Yawning).

Fast, yes. Supported, no.

https://ark.intel.com/content/www/us/en/ark/products/199288/intel-pentium-gold-g6400-processor-4m-cache-4-00-ghz.html

this is why we can't have nice things. I'll disable it :P

4 GHz and ancient SIMD. I don't know what's going on here.

runtime-sdk/modules/evm/src/backend.rs

contract-sdk/src/abi/crypto.rs

runtime-sdk/modules/evm/src/backend.rs

runtime-sdk/modules/evm/src/lib.rs

runtime-sdk/modules/evm/src/precompile/confidential.rs

runtime-sdk/modules/evm/src/backend.rs

runtime-sdk/modules/contracts/src/abi/oasis/crypto.rs

Yawning

I know you merged this, but 2 comments.

Yawning · 2022-12-09T10:34:21Z

contract-sdk/src/testing.rs

+impl Default for MockEnv {
+    fn default() -> Self {
+        Self {
+            rng: Arc::new(Mutex::new(XorShiftRng::seed_from_u64(0))),


Should this be deterministic?

it helps if you need to hardcode values into tests or something

Yawning · 2022-12-09T10:36:20Z

runtime-sdk/Cargo.toml

@@ -19,7 +19,8 @@ hmac = "0.11.0"
 sha2 = "0.9.8"
 sha3 = { version = "0.10.1", default-features = false }
 k256 = { version = "0.10.4" }
-schnorrkel = "0.10.2"
+schnorrkel = { version = "0.10.2", features = ["asm", "avx2_backend"] }


Fast, yes. Supported, no.

https://ark.intel.com/content/www/us/en/ark/products/199288/intel-pentium-gold-g6400-processor-4m-cache-4-00-ghz.html

nhynes force-pushed the nhynes/add-rng branch 2 times, most recently from 33622cc to 137e691 Compare July 6, 2022 12:00

nhynes commented Jul 6, 2022

View reviewed changes

runtime-sdk/modules/contracts/src/abi/oasis/crypto.rs Show resolved Hide resolved

nhynes commented Jul 6, 2022

View reviewed changes

runtime-sdk/modules/contracts/src/abi/oasis/crypto.rs Show resolved Hide resolved

nhynes force-pushed the nhynes/add-rng branch from e427a5f to c5caf77 Compare July 6, 2022 15:56

Yawning reviewed Jul 7, 2022

View reviewed changes

runtime-sdk/src/crypto/random.rs Outdated Show resolved Hide resolved

Yawning reviewed Jul 7, 2022

View reviewed changes

runtime-sdk/src/crypto/random.rs Outdated Show resolved Hide resolved

nhynes force-pushed the nhynes/add-rng branch from 52afffe to 8daaced Compare July 10, 2022 06:43

kostko reviewed Jul 11, 2022

View reviewed changes

bennetyee reviewed Sep 16, 2022

View reviewed changes

runtime-sdk/modules/contracts/src/abi/oasis/crypto.rs Outdated Show resolved Hide resolved

nhynes force-pushed the nhynes/add-rng branch from 8daaced to a81fc48 Compare September 27, 2022 07:53

nhynes added 8 commits December 6, 2022 21:54

runtime-sdk: add RNG

c48398f

fix lints

d42e052

Bump hello contract lockfile

ae3c65a

runtime-sdk: update everything else to edition 2021

fe24c97

Bump more lockfiles

11e252b

Use VRF to produce entropy

f187b39

evm: add precompile for random bytes

6ed4773

contract-sdk: add higher fidelity testing rng

27d4924

nhynes force-pushed the nhynes/add-rng branch from a81fc48 to 27d4924 Compare December 6, 2022 14:06

nhynes added 6 commits December 6, 2022 23:33

evm: use contextual precompiles

cfc6a61

evm: update precompile tests

01b94fd

tests/contracts: add random_bytes test

0dbbc59

tests/e2e: add evm rng test

c1c3037

evm: address rng review comments

3e41cbd

contracts: update wasm env

b8b6752

nhynes force-pushed the nhynes/add-rng branch from 2e0a445 to b8b6752 Compare December 7, 2022 07:51

nhynes added 2 commits December 7, 2022 22:35

contract-sdk: bump spec Cargo.locks

86e06f8

fix some tests

2175780

nhynes force-pushed the nhynes/add-rng branch 7 times, most recently from 9fb592b to 3e86f5e Compare December 8, 2022 18:44

evm: use abiencoding for precompiles

90e6d6c

nhynes force-pushed the nhynes/add-rng branch from 3e86f5e to 90e6d6c Compare December 8, 2022 18:46

nhynes requested a review from kostko December 9, 2022 04:39

fix contracts tests

de91b23

nhynes force-pushed the nhynes/add-rng branch from 15d71e2 to de91b23 Compare December 9, 2022 05:05

nhynes commented Dec 9, 2022

View reviewed changes

runtime-sdk/modules/evm/src/backend.rs Outdated Show resolved Hide resolved

nhynes added 2 commits December 9, 2022 15:33

evm: random bytes instead of random words

5e2cf95

evm: write key derivation test in regular solidity

6240c34

kostko reviewed Dec 9, 2022

View reviewed changes

runtime-sdk/modules/contracts/src/abi/oasis/crypto.rs Outdated Show resolved Hide resolved

Address review comments

a7680f3

nhynes force-pushed the nhynes/add-rng branch from c0f9d5f to a7680f3 Compare December 9, 2022 09:01

nhynes enabled auto-merge December 9, 2022 09:04

nhynes requested review from kostko and Yawning December 9, 2022 09:21

kostko approved these changes Dec 9, 2022

View reviewed changes

nhynes merged commit 8213e8a into main Dec 9, 2022

nhynes deleted the nhynes/add-rng branch December 9, 2022 09:26

Yawning reviewed Dec 9, 2022

View reviewed changes

nhynes mentioned this pull request Dec 9, 2022

runtime-sdk: remove schnorrkel cargo features #1221

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

runtime-sdk: add RNG #1037

runtime-sdk: add RNG #1037

nhynes commented Jul 6, 2022 •

edited

Loading

codecov bot commented Jul 6, 2022 •

edited

Loading

Yawning commented Jul 10, 2022

Yawning commented Sep 27, 2022

nhynes Dec 9, 2022

Yawning Dec 9, 2022

nhynes Dec 9, 2022 •

edited

Loading

Yawning left a comment

Yawning Dec 9, 2022

nhynes Dec 9, 2022

Yawning Dec 9, 2022

runtime-sdk: add RNG #1037

runtime-sdk: add RNG #1037

Conversation

nhynes commented Jul 6, 2022 • edited Loading

codecov bot commented Jul 6, 2022 • edited Loading

Codecov Report

Yawning commented Jul 10, 2022

Yawning commented Sep 27, 2022

nhynes Dec 9, 2022

Choose a reason for hiding this comment

Yawning Dec 9, 2022

Choose a reason for hiding this comment

nhynes Dec 9, 2022 • edited Loading

Choose a reason for hiding this comment

Yawning left a comment

Choose a reason for hiding this comment

Yawning Dec 9, 2022

Choose a reason for hiding this comment

nhynes Dec 9, 2022

Choose a reason for hiding this comment

Yawning Dec 9, 2022

Choose a reason for hiding this comment

nhynes commented Jul 6, 2022 •

edited

Loading

codecov bot commented Jul 6, 2022 •

edited

Loading

nhynes Dec 9, 2022 •

edited

Loading