Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-sdk/go: Add "cory" test key used by oasis-net-runner #1081

Merged
merged 1 commit into from Aug 24, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions client-sdk/go/testing/testing.go
Expand Up @@ -83,6 +83,8 @@ var (
Bob = newEd25519TestKey("oasis-runtime-sdk/test-keys: bob")
// Charlie is the test key C.
Charlie = newEd25519TestKey("oasis-runtime-sdk/test-keys: charlie")
// Cory is the default test key used by oasis-net-runner.
Cory = newEd25519TestKey("ekiden test entity key seed")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the name Cory from? It looks like we've mostly been using one name per first initial

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the entity key from Oasis Core, hence Cory :-)

The other idea was Debbie, the debug entity :P

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o lol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI Cory is deliberately separated from Alice, Bob, Charlie convention, because it's managed by the core tests/tooling (test-runner, net-runner). But it's still useful to have it around in Oasis CLI.

// Dave is the test key D.
Dave = newSecp256k1TestKey("oasis-runtime-sdk/test-keys: dave")
// Erin is the test key E.
Expand All @@ -97,6 +99,7 @@ var (
"alice": Alice,
"bob": Bob,
"charlie": Charlie,
"cory": Cory,
"dave": Dave,
"erin": Erin,
"frank": Frank,
Expand Down