New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime-sdk: Add support for consensus staking #1122
Conversation
d044912
to
b89a21e
Compare
7453bfc
to
722549d
Compare
b89a21e
to
e709852
Compare
722549d
to
9be92c0
Compare
97f1b19
to
c57d8fc
Compare
9be92c0
to
c3f8549
Compare
c57d8fc
to
4bfe14f
Compare
c3f8549
to
e2850eb
Compare
4bfe14f
to
ac4dcbb
Compare
e2850eb
to
847c5b4
Compare
ac4dcbb
to
bf5068d
Compare
847c5b4
to
804f1ae
Compare
83f0ca0
to
5da8b45
Compare
804f1ae
to
59d4176
Compare
60ca501
to
e1dc067
Compare
59d4176
to
7c9d931
Compare
Codecov Report
@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
+ Coverage 55.70% 56.30% +0.59%
==========================================
Files 124 126 +2
Lines 8652 8987 +335
==========================================
+ Hits 4820 5060 +240
- Misses 3790 3885 +95
Partials 42 42
|
7c9d931
to
3915e02
Compare
ab617aa
to
6fae30c
Compare
6fae30c
to
8162d9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self TODO: check the main part of the PR, changes in the consensus_accounts module.
} | ||
|
||
// Resolve height for the given epoch. | ||
let mut height = HEIGHT_LATEST; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, probably irrelevant? improvement: could start at the height of the smallest cached epoch that is higher than epoch
.
55c2983
to
656ade4
Compare
Also remove the module-specific epoch tracking from the rewards module and bump its version to v2 with a migration removing the old tracking state.
656ade4
to
a9c3b1d
Compare
a9c3b1d
to
dd60093
Compare
Based on #1118