Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Migrate code snippets from .md files to separate sources #1125

Merged
merged 4 commits into from Oct 3, 2022

Conversation

matevz
Copy link
Member

@matevz matevz commented Sep 16, 2022

Implements #1026:

  • migrates code snippets from hardcoded .md files to separate projects in examples/contract-sdk, examples/runtime-sdk and examples/client-sdk/go folders
  • bumps rust-toolchain for contract-sdk and runtime-sdk examples to 2022-08-06
  • removes strip feature from Cargo.toml since it's already included in rust 1.58 onwards by default
  • adds building, testing and linting of examples to CI
  • fixes typo manfiest -> manifest in github workflows, cliipy -> clippy

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1125 (a577d92) into main (e18a28e) will decrease coverage by 40.88%.
The diff coverage is n/a.

❗ Current head a577d92 differs from pull request most recent head 867b31c. Consider uploading reports for the commit 867b31c to get more accurate results

@@             Coverage Diff             @@
##             main    #1125       +/-   ##
===========================================
- Coverage   67.81%   26.93%   -40.89%     
===========================================
  Files         131       26      -105     
  Lines       11575     1916     -9659     
===========================================
- Hits         7850      516     -7334     
+ Misses       3693     1368     -2325     
  Partials       32       32               
Impacted Files Coverage Δ
...untime-sdk/src/modules/consensus_accounts/types.rs
runtime-sdk/modules/contracts/src/abi/mod.rs
contract-sdk/types/src/token.rs
runtime-sdk/src/modules/core/mod.rs
contract-sdk/specs/token/oas20/src/types.rs
contract-sdk/src/error.rs
runtime-sdk/src/testing/keys.rs
runtime-sdk/src/runtime.rs
runtime-sdk/src/testing/mock.rs
runtime-sdk/src/storage/typed.rs
... and 95 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matevz matevz force-pushed the matevz/feature/code-snippets branch 3 times, most recently from 23b6f01 to 1afb770 Compare September 19, 2022 15:36
@matevz matevz marked this pull request as ready for review September 26, 2022 10:31
@matevz matevz marked this pull request as draft September 26, 2022 10:33
@matevz matevz force-pushed the matevz/feature/code-snippets branch 4 times, most recently from 0c4b838 to 7a28195 Compare September 26, 2022 12:16
@matevz matevz marked this pull request as ready for review September 26, 2022 12:17
@matevz matevz force-pushed the matevz/feature/code-snippets branch 15 times, most recently from 9be2481 to 903a93c Compare September 29, 2022 09:28
@matevz matevz force-pushed the matevz/feature/code-snippets branch 20 times, most recently from 3f69028 to c14590f Compare September 29, 2022 11:57
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's a nice way to do it, thanks

@matevz matevz force-pushed the matevz/feature/code-snippets branch from c14590f to ccc1bcd Compare October 3, 2022 10:39
@matevz matevz force-pushed the matevz/feature/code-snippets branch from a577d92 to 867b31c Compare October 3, 2022 11:07
@matevz matevz enabled auto-merge October 3, 2022 11:08
@matevz matevz merged commit 7b57df2 into main Oct 3, 2022
@matevz matevz deleted the matevz/feature/code-snippets branch October 3, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants