Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-web/core: switch back to newly fixed getName #1162

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Oct 12, 2022

method descriptor .getName() will be fixed soon

grpc/grpc-web@4974a7b

@pro-wh pro-wh added the c:client-sdk/typescript Category: TypeScript client SDK label Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1162 (e2e3488) into main (9233a57) will increase coverage by 2.44%.
The diff coverage is n/a.

❗ Current head e2e3488 differs from pull request most recent head 3a2e7c4. Consider uploading reports for the commit 3a2e7c4 to get more accurate results

@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
+ Coverage   65.41%   67.86%   +2.44%     
==========================================
  Files         134      131       -3     
  Lines       12227    11615     -612     
==========================================
- Hits         7998     7882     -116     
+ Misses       4197     3701     -496     
  Partials       32       32              
Impacted Files Coverage Δ
...time-sdk/modules/contracts/src/abi/oasis/crypto.rs 4.93% <0.00%> (-1.54%) ⬇️
runtime-sdk/src/callformat.rs 65.32% <0.00%> (-0.56%) ⬇️
contract-sdk/src/abi/env.rs 0.00% <0.00%> (ø)
runtime-sdk/modules/contracts/src/lib.rs 66.18% <0.00%> (ø)
runtime-sdk/modules/contracts/src/wasm.rs 67.64% <0.00%> (ø)
...-sdk/modules/contracts/src/abi/oasis/validation.rs
contract-sdk/crypto/src/x25519.rs
contract-sdk/crypto/src/deoxysii.rs
contract-sdk/src/testing.rs 12.90% <0.00%> (+1.30%) ⬆️
runtime-sdk/modules/contracts/src/abi/oasis/mod.rs 66.66% <0.00%> (+5.50%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pro-wh
Copy link
Contributor Author

pro-wh commented Oct 12, 2022

wait no, it wasn't? 🤨

@pro-wh pro-wh marked this pull request as draft October 12, 2022 18:59
@pro-wh
Copy link
Contributor Author

pro-wh commented Oct 12, 2022

I'll incorporate this into the next grpc-web version bump

@pro-wh pro-wh marked this pull request as ready for review October 31, 2022 18:21
@pro-wh pro-wh merged commit 386ba0b into main Oct 31, 2022
@pro-wh pro-wh deleted the pro-wh/feature/getname branch October 31, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:client-sdk/typescript Category: TypeScript client SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants