runtime-sdk/callformat: randomize deoxysii nonce in simulation #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1171 +/- ##
=======================================
Coverage 65.40% 65.41%
=======================================
Files 134 134
Lines 12225 12227 +2
=======================================
+ Hits 7996 7998 +2
Misses 4197 4197
Partials 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nhynes
force-pushed
the
nhynes/rand-sim-nonce
branch
from
1ea36a4
to
2e30ff8
Compare
nhynes
changed the title
kostko
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR randomizes the nonce used to encrypt runtime responses when in simulate mode. This is useful for encrypted queries (as used by confidential EVM) which may see many queries being dispatched per block with corresponding loss of complete privacy. This could be fixed in client implementations, but you'd have to know to rekey your cipher before each call, which is not the most obvious thing to do.