Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-sdk/go/crypto: Fix public key comparison for pointer variants #1366

Merged
merged 2 commits into from May 15, 2023

Conversation

kostko
Copy link
Member

@kostko kostko commented May 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1366 (65d2158) into main (8039a75) will decrease coverage by 0.42%.
The diff coverage is 81.48%.

@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
- Coverage   56.14%   55.73%   -0.42%     
==========================================
  Files         120      124       +4     
  Lines        8522     8654     +132     
==========================================
+ Hits         4785     4823      +38     
- Misses       3700     3789      +89     
- Partials       37       42       +5     
Impacted Files Coverage Δ
client-sdk/go/crypto/signature/sr25519/sr25519.go 28.07% <72.72%> (ø)
client-sdk/go/crypto/signature/ed25519/ed25519.go 51.72% <87.50%> (ø)
...ent-sdk/go/crypto/signature/secp256k1/secp256k1.go 75.00% <87.50%> (+8.33%) ⬆️

... and 2 files with indirect coverage changes

@kostko kostko force-pushed the kostko/fix/csdk-go-pk-equal-ptr branch from 663ea0f to de44f12 Compare May 15, 2023 08:07
@kostko kostko enabled auto-merge May 15, 2023 08:55
@kostko kostko merged commit ca293cb into main May 15, 2023
26 of 27 checks passed
@kostko kostko deleted the kostko/fix/csdk-go-pk-equal-ptr branch May 15, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants