evm: add sha512-256 precompile #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
commented
Jul 10, 2023
ptrus
commented
Jul 10, 2023
kostko
reviewed
Jul 10, 2023
ptrus
force-pushed
the
ptrus/feature/sha512-256
branch
from
91f529c
to
e312751
Compare
Codecov Report
@@ Coverage Diff @@
## main #1408 +/- ##
==========================================
+ Coverage 56.42% 56.52% +0.10%
==========================================
Files 128 130 +2
Lines 9198 9238 +40
==========================================
+ Hits 5190 5222 +32
- Misses 3966 3974 +8
Partials 42 42
|
ptrus
force-pushed
the
ptrus/feature/sha512-256
branch
3 times, most recently
from
029a936
to
8fefeb6
Compare
ptrus
commented
Jul 10, 2023
kostko
reviewed
Jul 15, 2023
ptrus
force-pushed
the
ptrus/feature/sha512-256
branch
5 times, most recently
from
69a389a
to
145bb3e
Compare
kostko
approved these changes
Jul 17, 2023
| use super::{record_linear_cost, PrecompileResult}; | ||
|
|
||
| pub(super) fn call_sha512_256(handle: &mut impl PrecompileHandle) -> PrecompileResult { | ||
| // Costs were computed by benchmarking and comparing to SHA256 and using the already set SHA256 costs (unsure how those were obtained). |
There was a problem hiding this comment.
(unsure how those were obtained)
I believe those come from Ethereum.
There was a problem hiding this comment.
Ah thanks, indeed. Updated the comment.
ptrus
force-pushed
the
ptrus/feature/sha512-256
branch
from
145bb3e
to
733096f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.