runtime-sdk/modules/evm: Simplify revert reason encoding #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1479 +/- ##
==========================================
+ Coverage 59.18% 59.20% +0.02%
==========================================
Files 135 135
Lines 9609 9615 +6
==========================================
+ Hits 5687 5693 +6
Misses 3880 3880
Partials 42 42
|
kostko
force-pushed
the
kostko/fix/evm-revert-reason-simplify
branch
2 times, most recently
from
f11c1f8
to
3696b12
Compare
CedarMist
approved these changes
Sep 8, 2023
kostko
force-pushed
the
kostko/fix/evm-revert-reason-simplify
branch
from
3696b12
to
bd07c8e
Compare
Instead of attempting to decode simple ABI-encoded error strings, just return the entire data, base64-encoded.
kostko
force-pushed
the
kostko/fix/evm-revert-reason-simplify
branch
from
bd07c8e
to
85408ad
Compare
ptrus
approved these changes
Sep 12, 2023
ptrus
added a commit
to oasisprotocol/oasis-web3-gateway
that referenced
this pull request
Sep 20, 2023
ptrus
added a commit
to oasisprotocol/oasis-web3-gateway
that referenced
this pull request
Sep 20, 2023
ptrus
added a commit
to oasisprotocol/oasis-web3-gateway
that referenced
this pull request
Sep 20, 2023
ptrus
added a commit
to oasisprotocol/oasis-web3-gateway
that referenced
this pull request
Sep 20, 2023
ptrus
added a commit
to oasisprotocol/oasis-web3-gateway
that referenced
this pull request
Sep 20, 2023
ptrus
added a commit
to oasisprotocol/oasis-web3-gateway
that referenced
this pull request
Sep 20, 2023
ptrus
added a commit
to oasisprotocol/oasis-web3-gateway
that referenced
this pull request
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1478
Instead of attempting to decode simple ABI-encoded error strings, just return the entire data, base64-encoded.