runtime-sdk: remove compressed format requirement from ECDSA precompiles #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhynes
requested review from
kostko,
pro-wh,
ptrus and
peternose
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1570 +/- ##
==========================================
- Coverage 60.44% 60.41% -0.03%
==========================================
Files 139 139
Lines 9955 9949 -6
==========================================
- Hits 6017 6011 -6
Misses 3896 3896
Partials 42 42 ☔ View full report in Codecov by Sentry. |
peternose
approved these changes
Nov 27, 2023
github-actions bot
added a commit
that referenced
this pull request
Nov 27, 2023
…hynes/ec-precompile-more-key-formats runtime-sdk: remove compressed format requirement from ECDSA precompiles f2026f0
github-actions bot
added a commit
that referenced
this pull request
Nov 27, 2023
…/nhynes/ec-precompile-more-key-formats runtime-sdk: remove compressed format requirement from ECDSA precompiles f2026f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement that public keys provided to the ECDSA precompiles be in compressed format. Sometimes all the user has is an uncompressed one and the curve is not gas-efficient in Solidity. The restriction seems to be for no particular reason, so I removed it because it significantly limits the utility of the precompiles.