New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime-sdk: gas estimate binary search #981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #981 +/- ##
===========================================
- Coverage 67.94% 44.32% -23.62%
===========================================
Files 127 24 -103
Lines 10304 1507 -8797
===========================================
- Hits 7001 668 -6333
+ Misses 3278 816 -2462
+ Partials 25 23 -2 Continue to review full report at Codecov.
|
ptrus
force-pushed
the
ptrus/feature/gas-estimate-search
branch
6 times, most recently
from
June 9, 2022 09:05
729cdaf
to
d9fe655
Compare
kostko
reviewed
Jun 9, 2022
ptrus
force-pushed
the
ptrus/feature/gas-estimate-search
branch
6 times, most recently
from
June 16, 2022 12:30
0580071
to
dd0a52b
Compare
ptrus
force-pushed
the
ptrus/feature/gas-estimate-search
branch
4 times, most recently
from
June 17, 2022 10:57
e4cf233
to
da6ba24
Compare
ptrus
force-pushed
the
ptrus/feature/gas-estimate-search
branch
from
June 18, 2022 17:04
da6ba24
to
359ab83
Compare
kostko
reviewed
Jun 20, 2022
ptrus
force-pushed
the
ptrus/feature/gas-estimate-search
branch
from
June 20, 2022 08:25
359ab83
to
6257bf4
Compare
kostko
reviewed
Jun 20, 2022
ptrus
force-pushed
the
ptrus/feature/gas-estimate-search
branch
from
June 20, 2022 09:06
6257bf4
to
4240c1f
Compare
kostko
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configurable gas estimation via binary search support.
Enables fixing some EVM edge cases (#631) where gas estimation depends on actual gas limit used during estimation.
There are some EVM "gotcha's", hopefully the comments explain it well enough.