Add a notice before staking to top 20 validators

oasisprotocol · May 25, 2022 · a4ee663 · a4ee663
1 parent 52809a5
commit a4ee663
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 27 deletions.
diff --git a/src/app/components/AddEscrowForm/__tests__/index.test.tsx b/src/app/components/AddEscrowForm/__tests__/index.test.tsx
@@ -12,7 +12,7 @@ const renderComponent = (store: any, address: string, validatorStatus: Validator
   render(
     <Provider store={store}>
       <ModalProvider>
-        <AddEscrowForm validatorAddress={address} validatorStatus={validatorStatus} />
+        <AddEscrowForm validatorAddress={address} validatorStatus={validatorStatus} validatorRank={21} />
       </ModalProvider>
     </Provider>,
   )

diff --git a/src/app/components/AddEscrowForm/index.tsx b/src/app/components/AddEscrowForm/index.tsx
@@ -8,7 +8,7 @@ import { selectMinStaking } from 'app/state/network/selectors'
 import { Validator } from 'app/state/staking/types'
 import { transactionActions } from 'app/state/transaction'
 import { selectTransaction } from 'app/state/transaction/selectors'
-import { Box, Button, Form, TextInput } from 'grommet'
+import { Box, Button, CheckBox, Form, TextInput } from 'grommet'
 import React, { memo, useEffect, useState } from 'react'
 import { useTranslation } from 'react-i18next'
 import { useDispatch, useSelector } from 'react-redux'
@@ -18,12 +18,15 @@ import { TransactionStatus } from '../TransactionStatus'
 interface Props {
   validatorAddress: string
   validatorStatus: Validator['status']
+  validatorRank: number
 }
 
 export const AddEscrowForm = memo((props: Props) => {
   const { t } = useTranslation()
   const { launchModal } = useModal()
   const { error, success } = useSelector(selectTransaction)
+  const isTop20 = props.validatorRank <= 20
+  const [showNotice, setShowNotice] = useState(isTop20)
   const [amount, setAmount] = useState('')
   const dispatch = useDispatch()
   const minStaking = useSelector(selectMinStaking)
@@ -61,30 +64,47 @@ export const AddEscrowForm = memo((props: Props) => {
   }, [dispatch])
 
   return (
-    <Form onSubmit={submit}>
-      <Box direction="row" gap="small" pad={{ top: 'small' }}>
-        <Box background="background-front">
-          <TextInput
-            data-testid="amount"
-            id="amount-id"
-            name="amount"
-            placeholder={t('common.amount')}
-            type="number"
-            step="any"
-            min={minStaking}
-            value={amount}
-            onChange={event => setAmount(event.target.value)}
-            required
+    <>
+      {showNotice && (
+        <p>
+          {t(
+            'account.addEscrow.confirmDelegatingToTop.description',
+            'This validator is ranked in the top 20 by stake. Please consider delegating to a smaller validator to increase network security and decentralization.',
+          )}
+          <CheckBox
+            label={t('account.addEscrow.confirmDelegatingToTop.acknowledge', 'Delegate anyway')}
+            checked={!showNotice}
+            onChange={event => setShowNotice(!event.target.checked)}
           />
-        </Box>
-        <Button
-          label={t('account.addEscrow.delegate', 'Delegate')}
-          type="submit"
-          primary
-          style={{ borderRadius: '4px' }}
-        />
-      </Box>
-      <TransactionStatus error={error} success={success} />
-    </Form>
+        </p>
+      )}
+      {!showNotice && (
+        <Form onSubmit={submit}>
+          <Box direction="row" gap="small" pad={{ top: 'small' }}>
+            <Box background="background-front">
+              <TextInput
+                data-testid="amount"
+                id="amount-id"
+                name="amount"
+                placeholder={t('common.amount')}
+                type="number"
+                step="any"
+                min={minStaking}
+                value={amount}
+                onChange={event => setAmount(event.target.value)}
+                required
+              />
+            </Box>
+            <Button
+              label={t('account.addEscrow.delegate', 'Delegate')}
+              type="submit"
+              primary
+              style={{ borderRadius: '4px' }}
+            />
+          </Box>
+          <TransactionStatus error={error} success={success} />
+        </Form>
+      )}
+    </>
   )
 })
diff --git a/src/app/pages/StakingPage/Features/ValidatorList/ValidatorItem.tsx b/src/app/pages/StakingPage/Features/ValidatorList/ValidatorItem.tsx
@@ -19,7 +19,11 @@ export const ValidatorItem = (props: ValidatorProps) => {
     <Box pad="medium" background="background-contrast" data-testid="validator-item">
       <ValidatorInformations validator={validator} details={details} />
       {isWalletOpen && (
-        <AddEscrowForm validatorAddress={validator.address} validatorStatus={validator.status} />
+        <AddEscrowForm
+          validatorAddress={validator.address}
+          validatorStatus={validator.status}
+          validatorRank={validator.rank}
+        />
       )}
     </Box>
   )

diff --git a/src/locales/en/translation.json b/src/locales/en/translation.json
@@ -5,6 +5,10 @@
         "description": "Status of this validator is {{validatorStatus}}. Your delegation might not generate any rewards.",
         "title": "Are you sure you want to continue?"
       },
+      "confirmDelegatingToTop": {
+        "acknowledge": "Delegate anyway",
+        "description": "This validator is ranked in the top 20 by stake. Please consider delegating to a smaller validator to increase network security and decentralization."
+      },
       "delegate": "Delegate"
     },
     "loading": "Loading account",