Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI breaks after expanding a validator quickly after reload #501

Closed
lukaw3d opened this issue Dec 1, 2021 · 12 comments · Fixed by #611
Closed

UI breaks after expanding a validator quickly after reload #501

lukaw3d opened this issue Dec 1, 2021 · 12 comments · Fixed by #611
Assignees
Labels
bug Something isn't working

Comments

@lukaw3d
Copy link
Member

lukaw3d commented Dec 1, 2021

Peek 2021-12-01 06-55

@lukaw3d lukaw3d added the bug Something isn't working label Dec 1, 2021
@lukaw3d
Copy link
Member Author

lukaw3d commented Dec 1, 2021

@matevz Seems to be caused because props are readonly, and sort mutates original array

export const CommissionBounds = memo((props: Props) => {
const { t } = useTranslation()
if (props.bounds && props.bounds.length > 0) {
const items = props.bounds
.sort((a, b) => a.epochStart - b.epochStart)

@lukaw3d
Copy link
Member Author

lukaw3d commented Dec 1, 2021

if I add .slice() to clone array before, there's no error but:

click quickly after reload click slowly after reload
Screenshot from 2021-12-01 07-30-14 Screenshot from 2021-12-01 07-30-26

@matevz
Copy link
Member

matevz commented Dec 1, 2021

I can't seem to reproduce this. Are there issues with oasis monitor again? I do get random 400 and 500 errors in Chromium's incognito mode only.

@kinqsta
Copy link

kinqsta commented Dec 1, 2021

I just have same problem

Http response at 400 or 500 level
The above error occurred in task ft
    created by takeEvery(network/selectNetwork, ft)
    created by ht
Tasks cancelled due to error:
takeEvery(network/selectNetwork, ft)
D@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1047878
Ft@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1070696
Ut/<@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1069926
Ue@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1056709
Be@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1056515
xt@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1064004
Tt@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1064785
r.W@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1065728
r.R@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1065705

@lukaw3d
Copy link
Member Author

lukaw3d commented Dec 1, 2021

@kinqsta That looks like a different problem

@lukaw3d
Copy link
Member Author

lukaw3d commented Dec 1, 2021

@matevz I can't seem to reproduce this

Hm, I can't reproduce now either

@lukaw3d
Copy link
Member Author

lukaw3d commented Dec 1, 2021

Reproduced again by enabling Network Throttling: Fast 3G. Adding to description.

@matevz
Copy link
Member

matevz commented Dec 1, 2021

Reproduced again by enabling Network Throttling: Fast 3G. Adding to description.

Does it depend on the browser and incognito mode?

@lukaw3d
Copy link
Member Author

lukaw3d commented Dec 1, 2021

Nope, reproduced in normal Chrome and Firefox

@Boi4155
Copy link

Boi4155 commented Jan 22, 2022

I am able to reproduce this bug in any browser with or without extensions. I dont believe enabling Network Throttling: Fast 3G or running normally makes a difference on this bug.
error
I am an end user so It is difficult for me to debug when every variable and function is called Fi,Di,Li,Si. But it looks like the same bug error as posted before.
In my case specifically I cannot open info on the 'WePiggy Staking' validator. It is impossible for me to debond from them now. until this is fixed.
Another detail I dont know if matters or not is that the 'WePiggy Staking' is in between two other validators. I.e. it shows up in the middle for the UI.
Waiting an 'x' amount for time for 'y' to load makes no difference either it seems.
Please look into this, or offer an alternative to debonding as for now it is impossible. Thanks

@matevz
Copy link
Member

matevz commented Jan 24, 2022

@Boi4155 Can you check the Network tab if there are any failed requests? Maybe the oasismonitor was down for a moment and wallet couldn't connect to it?

@Boi4155
Copy link

Boi4155 commented Jan 25, 2022

I found nothing to do with failed requests there
Here's a video, although it is pretty much the same as the top one

walletBug.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants