Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to transaction history #81

Closed
tjanez opened this issue May 24, 2021 · 1 comment
Closed

Enhancements to transaction history #81

tjanez opened this issue May 24, 2021 · 1 comment
Labels
discussion Needs to be discussed before moving forward enhancement New feature or request
Milestone

Comments

@tjanez
Copy link
Member

tjanez commented May 24, 2021

Send transaction:
Txn history - 1 - Send

Delegate transaction:
Txn history - 2 - Delegate

  • I would suggest renaming the title to:
    • "Delegated 99,999.0 TEST"
  • I would suggest renaming "Validator" to "To" and showing a validator's name instead of account address if the address is for a known validator with an entity in metadata registry. The validator's name could be a link to a page with more info about it (link to block explorer?) or to go under "Active delegation" tabs for that validator?
  • Should the validator's avator also be shown somewhere?

Undelegate transaction:
Txn history - 3 - Undelegate

  • Same suggestions as for the Delegate transaction.
@Esya Esya added enhancement New feature or request good first issue labels May 24, 2021
@Esya Esya added this to the v1.0.0 milestone May 24, 2021
@Esya Esya added discussion Needs to be discussed before moving forward and removed good first issue labels May 24, 2021
@Esya
Copy link
Contributor

Esya commented May 24, 2021

Splitting this into two separate issues and closing this one :

#89 - I'll change Validator and To to Account to avoid misleading issues
#90 - This will be further down the line as there are multiple possible implementations for this (possibly actually fetching the metadata registry myself instead of relying on the explorer)

@Esya Esya closed this as completed May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Needs to be discussed before moving forward enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants