Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the designator in transaction history #89

Closed
Esya opened this issue May 24, 2021 · 2 comments
Closed

Change the designator in transaction history #89

Esya opened this issue May 24, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@Esya
Copy link
Contributor

Esya commented May 24, 2021

Change Validator and To to Account to avoid misleading issues inside TransactionHistory

@Esya Esya added the enhancement New feature or request label May 24, 2021
@Esya Esya added this to the v1.0.0 milestone May 24, 2021
@tjanez
Copy link
Member

tjanez commented May 27, 2021

Change Validator and To to Account to avoid misleading issues inside TransactionHistory

Perhaps it would be even better to not use the generic term Account but use the transaction's context to display a more meaningful thing.

For example, for a transfer txn where the wallet is the destination or for a reclaim escrow transaction, it would show From.

On the other had, for a transfer txn where the wallet is the source or for a add escrow transaction, it would show To.

I would also be nice if it would be unified with the Preview transaction's field names (#77).

@gparty
Copy link

gparty commented Mar 28, 2022

Thank you for reporting this issue. We have updated our Oasis Wallet with bug fixes and new features which should also solve mentioned issue above.

If you still encounter same or similar issue, please check our FAQ or send an email to our support team at wallet@oasisprotocol.org.

@gparty gparty closed this as completed Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants