Add pop-up notifs + show a notif when an address has been copied #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csillag
changed the title
csillag
force-pushed
the
csillag/indicate-address-copied
branch
from
252cc73
to
ac018e9
Compare
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
csillag
force-pushed
the
csillag/indicate-address-copied
branch
from
ac018e9
to
51e3963
Compare
Codecov Report
@@ Coverage Diff @@
## master #1012 +/- ##
==========================================
+ Coverage 88.59% 88.69% +0.10%
==========================================
Files 102 102
Lines 1762 1778 +16
Branches 406 412 +6
==========================================
+ Hits 1561 1577 +16
Misses 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
|
csillag
force-pushed
the
csillag/indicate-address-copied
branch
from
51e3963
to
c208e1c
Compare
csillag
force-pushed
the
csillag/indicate-address-copied
branch
from
c208e1c
to
41b6fbe
Compare
csillag
changed the title
buberdds
reviewed
Sep 26, 2022
csillag
force-pushed
the
csillag/indicate-address-copied
branch
3 times, most recently
from
803ed36
to
b879291
Compare
lukaw3d
reviewed
Sep 26, 2022
csillag
force-pushed
the
csillag/indicate-address-copied
branch
3 times, most recently
from
2206eeb
to
b069a53
Compare
|
@lukaw3d Thanks for all the input. I believe I have now addressed everything you mentioned. |
buberdds
reviewed
Sep 27, 2022
csillag
force-pushed
the
csillag/indicate-address-copied
branch
from
516e5c4
to
200a018
Compare
buberdds
approved these changes
Sep 28, 2022
csillag
force-pushed
the
csillag/indicate-address-copied
branch
from
200a018
to
1836405
Compare
lukaw3d
reviewed
Sep 28, 2022
Comment on lines
24
to
25
| expect(copy).toHaveBeenCalledWith(testAddress) | ||
| }) |
There was a problem hiding this comment.
I think you meant to check that notification shows up here :D
There was a problem hiding this comment.
Actually I wanted to test both the actual clipboard copy and the notification, since AddressBox had no tests before.
Now I have added a new test case below, specifically for the notification.
csillag
force-pushed
the
csillag/indicate-address-copied
branch
from
e99a1b4
to
aa38444
Compare
lukaw3d
reviewed
Sep 28, 2022
buberdds
reviewed
Sep 29, 2022
csillag
force-pushed
the
csillag/indicate-address-copied
branch
2 times, most recently
from
b58ce05
to
ac45682
Compare
csillag
force-pushed
the
csillag/indicate-address-copied
branch
from
ddb184b
to
974ffa0
Compare
csillag
force-pushed
the
csillag/indicate-address-copied
branch
from
974ffa0
to
d5e7492
Compare
lukaw3d
reviewed
Sep 29, 2022
lukaw3d
approved these changes
Sep 29, 2022
csillag
force-pushed
the
csillag/indicate-address-copied
branch
from
d5e7492
to
3378393
Compare
csillag
force-pushed
the
csillag/indicate-address-copied
branch
from
3378393
to
bdd587b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show a notification when address is copied.
The bigger chunk of this PR is actually integrating the notification widget (from Grommet) in such a way that it's convenient to use anywhere inside the app.
The method of integration is almost exactly the same how Modal windows are integrated.dialogs.
Fixes #271.