Remove global walletId and index accounts by address

[lukaw3d]

Motivation: let walletId = 0 is annoying to add to persisted state

[github-actions]

MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ EDITORCONFIG	editorconfig-checker	15		0	0.04s
✅ GIT	git_diff	yes		no	0.01s
✅ TSX	eslint	8	0	0	7.17s
✅ TYPESCRIPT	eslint	7	0	0	7.08s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

[codecov]

Codecov Report

Merging #1019 (0186a14) into master (ac76ab1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
- Coverage   88.57%   88.55%   -0.02%     
==========================================
  Files         101      101              
  Lines        1750     1747       -3     
  Branches      405      403       -2     
==========================================
- Hits         1550     1547       -3     
  Misses        200      200              

Flag	Coverage Δ
cypress	60.62% <100.00%> (-0.07%)	⬇️
jest	78.78% <70.58%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ponents/Toolbar/Features/AccountSelector/index.tsx	100.00% <100.00%> (ø)
src/app/components/TransactionModal/index.tsx	91.66% <100.00%> (ø)
...ge/Features/ImportAccountsSelectionModal/index.tsx	96.55% <100.00%> (+0.12%)	⬆️
src/app/state/wallet/index.ts	78.94% <100.00%> (ø)
src/app/state/wallet/saga.ts	98.33% <100.00%> (-0.06%)	⬇️
src/app/state/wallet/selectors.ts	100.00% <100.00%> (ø)
src/app/useRouteRedirects.tsx	100.00% <100.00%> (ø)

[csillag]

Instead of using { [address: string]: Wallet } I find the Record<string, Wallet> form easier to read.

[lukaw3d]

I think the key name address is helpful here. Too many things are a string

[csillag]

That's true. In fact it's so true that I would consider adding export type Address = string somewhere, and then consistently using Address instead of string wherever we are talking about addresses. (But that's a story of a different PR.)

[lukaw3d]

Yeah :D would we consistently use it tho? maybe :D

If we add it, we should alias it like StringifiedBigInt, or make it branded

oasis-wallet-web/src/types/StringifiedBigInt.ts

Lines 1 to 3 in 8be6fcb

	/** Redux can't serialize bigint fields, so we stringify them, and mark them. */
	export type StringifiedBigInt = string & PreserveAliasName
	interface PreserveAliasName extends String {}

[csillag]

Reviewed. LGTM.

(Almost feels like it should have been written like this from the start.)

[buberdds]

hmm I thought immer takes care of immutability and there is no need to use spread operator or Object.assign when assigning an object to state.

[lukaw3d]

Alright I'll risk it :D