Reduce bundle size (7.2MB -> 5.4MB) with consistent grommet imports #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
|
Considering the current build system, does using "import type" (instead of simple import) make any difference in the compiled product? I see a mixed practice in the current codebase, including this PR. |
csillag
approved these changes
Sep 27, 2022
|
Ah yeah, I'll remove that import type (has nothing to do with reducing size) |
lukaw3d
force-pushed
the
lw/consistent-grommet
branch
from
b4a73e2
to
70b4ad0
Compare
buberdds
approved these changes
Sep 28, 2022
internals/jest/jest.base-config.js
Outdated
| @@ -18,7 +18,7 @@ const config = { | |||
| transform: { | |||
| '^.+\\.(js|jsx|mjs|cjs|ts|tsx)$': '<rootDir>/internals/jest/babelTransform.js', | |||
| }, | |||
| transformIgnorePatterns: ['/node_modules/(?!(cborg)/)'], | |||
| transformIgnorePatterns: ['/node_modules/(?!(cborg)|(grommet/es6)|(grommet-icons/es6)/)'], | |||
There was a problem hiding this comment.
I would go with one capturing group
transformIgnorePatterns: ['/node_modules/(?!(cborg|grommet/es6|grommet-icons/es6)/)'],
lukaw3d
force-pushed
the
lw/consistent-grommet
branch
from
70b4ad0
to
b219841
Compare
lukaw3d
force-pushed
the
lw/consistent-grommet
branch
from
b219841
to
5f9fae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.