Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle default tooltips and toast notifications #1098

Merged
merged 2 commits into from Oct 25, 2022
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Oct 21, 2022

Before After
b c

Adds a solid background and removes the shadow to be consistent with SidebarTooltip
localhost_3000_account_oasis1qqetax7q9gh5jxasjqj2gkpvntwamudc75vnt0rl

@github-actions
Copy link

github-actions bot commented Oct 21, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY checkov yes no 13.54s
✅ REPOSITORY git_diff yes no 0.01s
✅ TSX eslint 1 0 0 5.13s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lukaw3d lukaw3d mentioned this pull request Oct 21, 2022
10 tasks
@csillag
Copy link
Contributor

csillag commented Oct 22, 2022

Shouldn't we do something similar about the notifications, too? The shadow / elevation seems to be an overkill.

image

Copy link
Contributor

@csillag csillag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is OK.
(It would be nice adjust Notification, too, but from a cursory look of the available settings, I'm not sure it's trivially possible.)

@lukaw3d
Copy link
Member Author

lukaw3d commented Oct 25, 2022

Good reminder!

@lukaw3d lukaw3d changed the title Restyle default tooltips (add background to PasswordField tooltip) Restyle default tooltips and toast notifications Oct 25, 2022
@lukaw3d lukaw3d merged commit cde4367 into master Oct 25, 2022
@lukaw3d lukaw3d deleted the lw/tip-style branch October 25, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants