Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert dump_validators from jest to bash #1113

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Convert dump_validators from jest to bash #1113

merged 2 commits into from
Oct 27, 2022

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Oct 27, 2022

Instead of abusing jest to call typescript getOasisscanAPIs().getAllValidators() this saves curl response.

(relating to #815 (comment): this would unblock globally mocking fetch in jest)

@github-actions
Copy link

github-actions bot commented Oct 27, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.01s
✅ BASH bash-exec 1 0 0.0s
✅ BASH shellcheck 1 0 0.01s
✅ BASH shfmt 1 0 0 0.01s
✅ EDITORCONFIG editorconfig-checker 5 0 0.01s
✅ JSON eslint-plugin-jsonc 1 0 0 0.8s
✅ JSON jsonlint 1 0 0.21s
✅ JSON prettier 1 0 0 0.43s
✅ JSON v8r 1 0 6.15s
✅ REPOSITORY checkov yes no 12.16s
✅ REPOSITORY git_diff yes no 0.0s
✅ TYPESCRIPT eslint 2 0 0 5.38s
✅ YAML prettier 1 0 0 0.63s
✅ YAML v8r 1 0 2.08s
✅ YAML yamllint 1 0 0.2s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #1113 (cd2df49) into master (659c554) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
- Coverage   83.68%   83.54%   -0.14%     
==========================================
  Files         121      121              
  Lines        2249     2249              
  Branches      539      539              
==========================================
- Hits         1882     1879       -3     
- Misses        367      370       +3     
Flag Coverage Δ
cypress 51.80% <0.00%> (ø)
jest 76.70% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/state/staking/saga.ts 85.36% <100.00%> (ø)
src/app/state/account/saga.ts 83.01% <0.00%> (-5.67%) ⬇️

@lukaw3d lukaw3d force-pushed the lw/dump-bash branch 3 times, most recently from 3a5895c to 25a323a Compare October 27, 2022 01:34
@lukaw3d lukaw3d merged commit 6e6fb11 into master Oct 27, 2022
@lukaw3d lukaw3d deleted the lw/dump-bash branch October 27, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants