Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modals scrolling to top on every selection #1157

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Nov 15, 2022

Fixes #1056

@github-actions
Copy link

github-actions bot commented Nov 15, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY checkov yes no 13.24s
✅ REPOSITORY git_diff yes no 0.0s
✅ TSX eslint 1 0 0 4.15s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1157 (32f3b45) into master (34fdf49) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
+ Coverage   84.52%   84.60%   +0.08%     
==========================================
  Files         127      127              
  Lines        2384     2384              
  Branches      574      574              
==========================================
+ Hits         2015     2017       +2     
+ Misses        369      367       -2     
Flag Coverage Δ
cypress 52.09% <100.00%> (ø)
jest 77.88% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/ResponsiveLayer/index.tsx 100.00% <100.00%> (ø)
src/app/state/account/saga.ts 83.01% <0.00%> (-5.67%) ⬇️
src/app/state/transaction/saga.ts 68.79% <0.00%> (+0.70%) ⬆️
src/app/state/transaction/index.ts 94.28% <0.00%> (+11.42%) ⬆️

@lukaw3d lukaw3d merged commit b12d742 into master Nov 16, 2022
@lukaw3d lukaw3d deleted the lw/modal-scroll branch November 16, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportAccountsSelector scrolls to top on every selection
2 participants