Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version tag in footer #1192

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Dec 5, 2022

Issue

Closes #1118

Solution

Latest tag(version) should be displayed in the footer, linking to the matching tag in releases.

  • git describe --tags --abbrev=0 gets the latest single tag in commit history - possible to add --exact-match, to show only tags on current commit, but will break test builds;
  • env variable REACT_APP_BUILD_VERSION added for vx.x tag;

Caveats

git describe --tags --abbrev=0 will throw an error, if there are no tags added - which is probably what we want anyway.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1192 (19e4650) into master (4041391) will increase coverage by 0.32%.
The diff coverage is 100.00%.

❗ Current head 19e4650 differs from pull request most recent head 3c530fd. Consider uploading reports for the commit 3c530fd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
+ Coverage   80.29%   80.61%   +0.32%     
==========================================
  Files         141      141              
  Lines        2654     2657       +3     
  Branches      652      654       +2     
==========================================
+ Hits         2131     2142      +11     
+ Misses        523      515       -8     
Flag Coverage Δ
cypress 51.28% <100.00%> (+0.05%) ⬆️
jest 73.83% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Footer/index.tsx 100.00% <100.00%> (ø)
src/app/state/transaction/saga.ts 68.79% <0.00%> (+0.70%) ⬆️
src/app/state/account/saga.ts 88.67% <0.00%> (+5.66%) ⬆️
src/app/state/transaction/index.ts 94.28% <0.00%> (+11.42%) ⬆️

src/app/components/Footer/index.tsx Outdated Show resolved Hide resolved
src/app/components/Footer/index.tsx Show resolved Hide resolved
@lubej lubej requested a review from buberdds December 6, 2022 09:34
Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge two last commits into one something like "Open footer links in a new tab".

optional: in terms of guards we could either check tag format in UI or maybe just add comment in gh action next to fetch-depth that it's needed to render footer correctly.

@lubej lubej merged commit a16d9ce into oasisprotocol:master Dec 6, 2022
@lubej lubej deleted the ml/feature/add-version-tag branch December 6, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display version tag in the footer when a tagged version is built
2 participants