Refactor selecting network initially to avoid sync timing issues #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Deploying with
|
| Latest commit: |
d216857
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://44d46b4a.oasis-wallet.pages.dev |
| Branch Preview URL: | https://lw-sync-time.oasis-wallet.pages.dev |
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
buberdds
approved these changes
Mar 21, 2023
|
Slightly refactored default network type, so that tests with configureAppStore can stay simple as they were |
Reverts part of c125984 and re-fixes #975 (comment) Instead of waiting for tabs to be synced before selecting network initially: - initialize selecting network without syncing that action - using takeLatest cancel initialization task if tabs sync during selectNetwork
Codecov Report
@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
- Coverage 84.77% 84.15% -0.63%
==========================================
Files 142 142
Lines 3612 3628 +16
Branches 661 667 +6
==========================================
- Hits 3062 3053 -9
- Misses 550 575 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #792 (comment)
Reverts part of c125984 and re-fixes #975 (comment)
Instead of waiting for tabs to be synced before selecting network initially: