ParaTimes: fix Consensus amount not representable bug #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1346 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 142 142
Lines 3628 3628
Branches 667 667
=======================================
Hits 3056 3056
Misses 572 572
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently bug
Unknown gRPC error: client: transaction check failed: runtime error: module: consensus code: 5 message: consensus: amount not representablecan occur during withdraws from EVM ParaTimes.In both cases, deposit to ParaTime from Consensus and withdraw from ParaTime to Consensus, we need valid Consensus amounts.