ParaTimes: cancel transfer instead of navigating back to ParaTime selection #1352
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
==========================================
- Coverage 84.44% 84.24% -0.21%
==========================================
Files 142 142
Lines 3652 3631 -21
Branches 668 666 -2
==========================================
- Hits 3084 3059 -25
- Misses 568 572 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
buberdds
changed the title
|
|
||
| expect(navigateToWithdraw).toHaveBeenCalled() | ||
| expect(clearTransactionForm).toHaveBeenCalled() |
There was a problem hiding this comment.
could we instead have a test more like
sample: fill in Cipher recipient go back to the first step, select emerald, click next and we have Oasis addr in recipient input where we need eth addr.
There was a problem hiding this comment.
That belongs to e2e test more. I can add one and comment it out temporary. Which one is now preferable in Wallet: cypress or playwright ?
Deploying with
|
| Latest commit: |
0c75a20
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d3f414eb.oasis-wallet.pages.dev |
| Branch Preview URL: | https://mz-paratimeformreset.oasis-wallet.pages.dev |
buberdds
force-pushed
the
mz/paraTimeFormReset
branch
from
1a5f6b4
to
52861d1
Compare
buberdds
force-pushed
the
mz/paraTimeFormReset
branch
from
52861d1
to
0c75a20
Compare
| @@ -0,0 +1,30 @@ | |||
| // Uncomment when ParaTimes are released | |||
There was a problem hiding this comment.
I would have e2e test running already with e.g.
const canAccessParaTimesRoute =
process.env.REACT_APP_E2E_TEST && // Remove when we can officially show ParaTimes to usersThere was a problem hiding this comment.
totally forgot about this env, thx
Currently user can navigate back to ParaTime selector step which can lead to weird experience as we keep data for next steps.
sample: fill in Cipher recipient go back to the first step, select emerald, click next and we have Oasis addr in recipient input where we need eth addr.