ParaTimes: take into account fee amount when calc max button value #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Deploying with
|
| Latest commit: |
d3e5d01
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://83f98973.oasis-wallet.pages.dev |
| Branch Preview URL: | https://mz-paratimemaxvalue.oasis-wallet.pages.dev |
buberdds
force-pushed
the
mz/paraTimeMaxValue
branch
from
de0248e
to
f1c258d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
+ Coverage 84.25% 84.44% +0.19%
==========================================
Files 142 142
Lines 3632 3652 +20
Branches 667 668 +1
==========================================
+ Hits 3060 3084 +24
+ Misses 572 568 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
buberdds
force-pushed
the
mz/paraTimeMaxValue
branch
from
f1c258d
to
c2acf8c
Compare
lukaw3d
reviewed
Mar 27, 2023
| @@ -12,6 +12,7 @@ export const initialState: ParaTimesState = { | |||
| confirmTransfer: false, | |||
| confirmTransferToValidator: false, | |||
| confirmTransferToForeignAccount: false, | |||
| defaultFeeAmount: '', | |||
There was a problem hiding this comment.
How come the default is in state and in TransactionForm? I only expected feeAmount
There was a problem hiding this comment.
feeAmount is provided by user. defaultFee value should not be visible in UI. With one prop feeAmount we could have scenario like: user is not interacting with fee amount (advance field), advance to next step, click previous, and at this point feeAmount input would have a value of default fee, but user did not interact with an input at all.
buberdds
force-pushed
the
mz/paraTimeMaxValue
branch
3 times, most recently
from
bc7e73a
to
d5c4e98
Compare
lukaw3d
approved these changes
Mar 29, 2023
buberdds
force-pushed
the
mz/paraTimeMaxValue
branch
from
d5c4e98
to
d3e5d01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "insufficient balance to pay fees" error when using max button.