Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for privateToEthAddress #1362

Merged
merged 2 commits into from Mar 29, 2023
Merged

Add failing test for privateToEthAddress #1362

merged 2 commits into from Mar 29, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Mar 29, 2023

Related to oasisprotocol/explorer@dbdabe6

Apparently none of our existing jest tests touch multiple imports from @ethereumjs/util that check instanceof Uint8Array internally. Otherwise we would have odd failures. Added a skipped test as a reminder

@lukaw3d lukaw3d requested a review from buberdds March 29, 2023 21:16
@github-actions
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.02s
✅ REPOSITORY checkov yes no 16.88s
✅ REPOSITORY git_diff yes no 0.0s
✅ TYPESCRIPT eslint 3 0 0 4.57s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@csillag csillag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaw3d lukaw3d merged commit 25e1d72 into master Mar 29, 2023
11 checks passed
@lukaw3d lukaw3d deleted the lw/jest-uint8-fail branch March 29, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants