Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button to trigger a fatal error in e2e page #1425

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Apr 25, 2023

Just useful for development

@lukaw3d lukaw3d requested a review from buberdds April 25, 2023 13:02
@github-actions
Copy link

github-actions bot commented Apr 25, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY checkov yes no 23.04s
✅ REPOSITORY git_diff yes no 0.01s
✅ TSX eslint 1 0 0 5.6s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8acf260
Status: ✅  Deploy successful!
Preview URL: https://2cc5729e.oasis-wallet.pages.dev
Branch Preview URL: https://lw-fatal-e2e.oasis-wallet.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #1425 (8acf260) into master (7aa5977) will decrease coverage by 0.06%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
- Coverage   83.27%   83.22%   -0.06%     
==========================================
  Files         154      154              
  Lines        4006     4017      +11     
  Branches      726      726              
==========================================
+ Hits         3336     3343       +7     
- Misses        670      674       +4     
Flag Coverage Δ
cypress 50.91% <83.33%> (+0.08%) ⬆️
jest 78.45% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/pages/E2EPage/index.tsx 47.61% <71.42%> (+5.68%) ⬆️

Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint task is failing

@lukaw3d lukaw3d merged commit c1585ec into master Apr 25, 2023
10 of 11 checks passed
@lukaw3d lukaw3d deleted the lw/fatal-e2e branch April 25, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants