Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ParaTimeSelection padding match placeholder, option, and value #1426

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Apr 25, 2023

Fixes #1385

Placeholder Options Value
d80a2c49 oasis-wallet pages dev_account_oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90_paratimes d80a2c49 oasis-wallet pages dev_account_oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90_paratimes (2) d80a2c49 oasis-wallet pages dev_account_oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90_paratimes (1)

@lukaw3d lukaw3d requested a review from buberdds April 25, 2023 22:20
@github-actions
Copy link

github-actions bot commented Apr 25, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.01s
✅ REPOSITORY checkov yes no 17.54s
✅ REPOSITORY git_diff yes no 0.0s
✅ TSX eslint 2 0 0 4.19s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3210455
Status: ✅  Deploy successful!
Preview URL: https://080f20db.oasis-wallet.pages.dev
Branch Preview URL: https://lw-select-padding.oasis-wallet.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #1426 (3210455) into master (96612f8) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1426      +/-   ##
==========================================
- Coverage   83.23%   83.17%   -0.07%     
==========================================
  Files         154      154              
  Lines        4015     4018       +3     
  Branches      726      726              
==========================================
  Hits         3342     3342              
- Misses        673      676       +3     
Flag Coverage Δ
cypress 50.88% <0.00%> (-0.04%) ⬇️
jest 78.38% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/styles/theme/ThemeProvider.tsx 100.00% <ø> (ø)
...pp/pages/ParaTimesPage/ParaTimeSelection/index.tsx 92.59% <100.00%> (+0.92%) ⬆️

... and 1 file with indirect coverage changes

@lukaw3d
Copy link
Member Author

lukaw3d commented Apr 26, 2023

oops it is still 2px off

@lukaw3d lukaw3d merged commit 205ae52 into master Apr 26, 2023
@lukaw3d lukaw3d deleted the lw/select-padding branch April 26, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix annoying ParaTime dropdown height change
2 participants